Skip to content

Conversation

gibson042
Copy link
Member

Noticed in passing.

@gibson042 gibson042 requested a review from ptomato September 22, 2025 05:05
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.80%. Comparing base (1a089eb) to head (abe0d54).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
polyfill/lib/calendar.mjs 98.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   96.80%   96.80%   -0.01%     
==========================================
  Files          22       22              
  Lines       10131    10129       -2     
  Branches     1834     1835       +1     
==========================================
- Hits         9807     9805       -2     
  Misses        273      273              
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have time to get a full understanding of this change, but it looks correct. I do get about a 1% speedup measuring differences over various year ranges.

If you like I can write a snapshot test comparing some results before and after.

@gibson042
Copy link
Member Author

If you like I can write a snapshot test comparing some results before and after.

Thanks; that'd be great!

@gibson042 gibson042 force-pushed the gibson-2025-09-chinese-month-list branch from b48c546 to 87efd1b Compare September 23, 2025 05:28
Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, preserves all the results, including existing bugs, when run against 65884 pairs of various dates between 1900 and 2100 (the non-implementation-approximated validity range for this calendar)

@ptomato ptomato force-pushed the gibson-2025-09-chinese-month-list branch from fe78136 to 56020dd Compare September 23, 2025 21:07
@ptomato ptomato force-pushed the gibson-2025-09-chinese-month-list branch from 56020dd to abe0d54 Compare September 23, 2025 21:11
@ptomato ptomato merged commit f4d86e5 into tc39:main Sep 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants