gibson042 ECMA-402 Editor review

[gibson042]

Overall looks reasonable to me. I opened #6 with some editorial tweaks. Further comments:

• Naming the new parameters/aliases/slots stringDigits/[[StringDigits]] reads like they contain the digits theirselves, rather than a count. I recommend instead using something like sourceDigitCount/[[DigitCount]].

[eemeli]

I have no strong feelings about the name of the internal slot. My intent with the current naming is to include a reference to the value only having a non-zero value if the value being formatted is defined by a string. If that's not important to retain, then e.g. [[SignificantDigits]] would also be a valid alternative.

[gibson042]

The problem I'm pointing out is basing the term on "Digits" rather than "Count"—the former name suggests to me that the corresponding value is an actual sequence of digits.

[eemeli]

Ah, so would [[StringDigitCount]] work?

[gibson042]

Ah, so would [[StringDigitCount]] work?

👍