Skip to content

Editorial: Remove the mention of the "the first substring" #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2021

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Apr 15, 2021

Close #559
Remove the misleading usage of the "first" substring which imply it is possible to have second or rest but under condition which are not possible.

@FrankYFTang FrankYFTang changed the title Remove the mention of the "the first substring" Editorial: Remove the mention of the "the first substring" Apr 15, 2021
@ryzokuken
Copy link
Member

@gibson042 @leobalter can either of you give this a final +1?

@anba
Copy link
Contributor

anba commented Apr 26, 2021

Nit: There should be a "the" before each occurrence of "Unicode locale extension sequence" in the modified lines.


The spec also contains steps like:

Let noExtensionsLocale be the String value that is locale with all Unicode locale extension sequences removed.

which also kind of implies that multiple Unicode locale extension sequences are possible within a language tag, even though a structurally valid language tag can contain at most one Unicode locale extension sequence. Should this also be changed, for example by switching from "all" to "any"?

Let noExtensionsLocale be the String value that is locale with any Unicode locale extension sequence removed.

@FrankYFTang
Copy link
Contributor Author

@anba @ryzokuken PTAL

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @anba @gibson042 @leobalter please approve.

@ryzokuken
Copy link
Member

Merging editorial PR after multiple positive reviews and two editor signoffs.

@ryzokuken ryzokuken merged commit 43ed90c into master May 22, 2021
@ryzokuken ryzokuken deleted the FrankYFTang-patch-2 branch May 22, 2021 05:40
@ryzokuken ryzokuken added the editorial Involves an editorial fix label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Involves an editorial fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"the first substring of" and "the first Unicode locale extension sequence" is confusing and misleading
5 participants