Skip to content

Editorial: Clean up structure, references, and common patterns #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 24, 2021

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 commented Apr 9, 2021

This PR can be reviewed in entirety, or commit by commit.

First clean build in a long time! https://github.com/tc39/ecma402/pull/562/checks?check_run_id=2303361976

******> npm run "build-master"

> [email protected] build-master /home/runner/work/ecma402/ecma402
> mkdir out && cp -R img out && ecmarkup --lint-spec --verbose spec/index.html out/index.html --css out/ecmarkup.css --js out/ecmarkup.js

[2021-04-09T06:03:58.006Z] Loading biblios...
[2021-04-09T06:03:58.049Z] Loading imports...
[2021-04-09T06:03:58.492Z] Building boilerplate...
[2021-04-09T06:03:58.579Z] Linting...
[2021-04-09T06:03:58.806Z] Walking document, building various elements...
[2021-04-09T06:03:59.934Z] Building SDO map...
[2021-04-09T06:04:00.029Z] Finding offsets for replacement algorithm steps...
[2021-04-09T06:04:00.029Z] Autolinking terms and abstract ops...
[2021-04-09T06:04:01.974Z] Linking xrefs...
[2021-04-09T06:04:02.091Z] Linking non-terminal references...
[2021-04-09T06:04:02.092Z] Linking production references...
[2021-04-09T06:04:02.092Z] Building reference graph...
[2021-04-09T06:04:02.121Z] Highlighting syntax...
[2021-04-09T06:04:02.223Z] Building table of contents...
[2021-04-09T06:04:02.286Z] Found existing js link to ecmarkup.js, skipping inlining...
[2021-04-09T06:04:02.297Z] Found existing css link to ecmarkup.css, skipping inlining...
[2021-04-09T06:04:02.388Z] Done.
[2021-04-09T06:04:02.388Z] Writing output...
got status code 0

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ryzokuken
Copy link
Member

@gibson042 can we merge this?

@leobalter @sffc @FrankYFTang one additional review would be great :D

@ryzokuken
Copy link
Member

Editorial PR with multiple approvals and editor sign-offs, merging.

@ryzokuken ryzokuken merged commit 6163a18 into tc39:master May 24, 2021
@ryzokuken ryzokuken added the editorial Involves an editorial fix label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Involves an editorial fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants