Skip to content

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 17, 2023

Regression introduced in: #6969 see #6969 (comment)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 17, 2023 00:59
@amrbashir amrbashir requested a review from tweidinger June 17, 2023 01:02
@amrbashir amrbashir force-pushed the fix/core/require-leading-dot branch from de63c29 to 75d61d5 Compare June 17, 2023 11:27
@lucasfernog lucasfernog merged commit 066c09a into 1.x Jun 17, 2023
@amrbashir amrbashir deleted the fix/core/require-leading-dot branch June 17, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

4 participants