-
Notifications
You must be signed in to change notification settings - Fork 47
Add a function to get tasks from multiple kinds in one pass #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b1a20b9
to
5e8e72f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a test for the new function?
src/taskgraph/generator.py
Outdated
""" | ||
Get all the tasks of a given kind. | ||
Get all the tasks of a the given kinds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get all the tasks of a the given kinds. | |
Get all the tasks of the given kinds. |
Adding tests unveils that the fake_loader here sets |
There seem to be other places where we assume the name matches the label e.g. taskgraph/src/taskgraph/actions/retrigger.py Line 150 in 6317207
taskgraph/src/taskgraph/transforms/task.py Line 1331 in 6317207
|
This is especially useful when some of the kinds the caller is interested in is a dependency of another kind.
5e8e72f
to
7ce050c
Compare
This is especially useful when some of the kinds the caller is interested in is a dependency of another kind.