Skip to content

Fixing the load ci step #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

madflojo
Copy link
Member

@madflojo madflojo commented Nov 4, 2023

Summary by CodeRabbit

  • Chores
    • Updated the target URL for load testing configuration.

Copy link
Contributor

coderabbitai bot commented Nov 4, 2023

Walkthrough

The primary change in this update is a modification to the load test configuration. The target URL for the load test has been updated from http://localhost:8080 to http://localhost/, simplifying the URL and potentially improving the efficiency of the load test.

Changes

File Summary
.github/workflows/load.yml The target URL for the load test configuration has been updated from http://localhost:8080 to http://localhost/.

Poem

🍂 As the leaves fall, we tweak and tune, 🍁

In the light of the November moon. 🌕

A URL change, small but neat, 🌐

Makes our load test skip a beat. 💓

Celebrate the change, oh so slight, 🎉

As we code into the night. 🌃

Here's to progress, step by step, 🐾

In our codebase's rhythmic pep. 🎶


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 62fcc19 and 283ce74.
Files selected for processing (1)
  • .github/workflows/load.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/load.yml

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fcac6d) 83.03% compared to head (283ce74) 83.03%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files          12       12           
  Lines        1167     1167           
=======================================
  Hits          969      969           
  Misses        152      152           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madflojo madflojo merged commit 9a525ae into tarmac-project:main Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant