WB-1389: Fakeable trait issue - Event Machine #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oving unnecessary checks
…stCountGuard behavior
…dReturn calls Introduce a test case to verify handling of multiple `shouldReturn` calls within the same test. Ensures consistent behavior when alternating return values in `TestCountGuard`.
…un and shouldReturn calls Introduce a new test case to validate combining `shouldRun` and `shouldReturn` calls within the same test. Confirms consistent behavior of `TestCountGuard` when alternating between the methods.
…dRun calls Add a test case to ensure proper handling of multiple `shouldRun` calls across different behaviors. Validate consistent behavior of `TestIncrementAction` and `TestCountGuard` when expectations change dynamically.
deligoez
approved these changes
Jun 10, 2025
…configurations Update tests to validate `shouldRun` with various configurations, including multiple calls and resets. Improve coverage for dynamic behavior of `TestIncrementAction`.
…ldReturn without fake call Validate that `shouldReturn` implicitly fakes the guard and maintains expected behavior during execution.
…ldRun without fake call Validate that `shouldRun` implicitly fakes the guard and maintains expected behavior during execution.
…unt verification Introduce a test case to validate accurate expectation counts for `TestIncrementAction`. Ensure exception is thrown when expectations are unmet.
… with reset and ordered expectations Improve tests to include reset functionality and ordered return value scenarios for `TestCountGuard`. Ensure consistent handling of consecutive return values and enhance test coverage.
…ation with assertNotRan Validate handling of consecutive `never()` calls for `TestIncrementAction` without invocation. Ensure no exceptions are thrown for `assertNotRan`.
…ple mock configurations Introduce a test case to validate behavior when chaining configurations for `shouldRun` on `TestIncrementAction`. Ensure consistent handling of mocked actions and context updates.
…ests Combine redundant test cases for `resetAllFakes`, ensuring proper verification of fake resets, container cleanup, and mockery expectations in a single test. Improve clarity and maintainability.
… isolation and consistency Improve test clarity by consolidating assertions for fake isolation and consistency after resets. Remove redundant comments and streamline test structure for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.