Proposal to reintroduce catwalks at the bottom of the block #193

snailcase · 2025-03-14T22:58:28Z

This is a proposal to reintroduce the option to have catwalk blocks on the bottom of a block, while keeping catwalk railings as separate items and blocks.

Overview of changes

Catwalks can be toggled with a wrench between a top position (default) and a bottom position.
- For this, two new block properties are introduced: CATWALK_TOP and CATWALK_BOTTOM.
Rails can be placed into bottom catwalks.
- For this, four new block properties are introduced: RAILING_[NORTH|EAST|SOUTH|WEST]
Catwalk blocks and railing blocks are still distinct blocks, and any existing blocks in player’s worlds shouldn’t be affected by these changes.

Placing Catwalks

Placing a catwalk still works the same way: The catwalk will initially be at the top of the block.
Wrenching a catwalk now toggles it between the top and bottom of the block.
Extending catwalks (using the placement helpers) will consider the placement of the catwalk that is being extended.

Placing Railings

Placing a railing on a catwalk block will have different effects depending on the state of the catwalk block:
- If the catwalk is at the bottom of the block then the railing will be placed into the catwalk block, using the direction that the player is facing.
- If the catwalk block is in the top position, the railing will simply be placed in the block above. This hasn’t changed.
Railings can still be placed as standalone railing blocks.

Interacting with catwalk blocks

A catwalk block with railings can be wrenched to rotate it.
Shift-wrenching a catwalk block will return the component that the player is looking at (i.e. either a railing or the catwalk)

Interacting with railing blocks

The existing railing blocks are mostly unchanged. However, players can now place a catwalk into a railing block. This will replace the railing block with a catwalk block.

Things I’ve tested

The additional block properties introduce some complexity, and I’ve tried my best to test a lot of scenarios. Here’s a list of things I’ve tested:

The hitbox of the catwalk block correctly changes based on the position of the catwalk and the presence of railings.
The BOTTOM block property (i.e. the full-block model for catwalks that are above support blocks) is still working. The full-block model is only visible if the catwalk is at the top of the block
In schematics, the cost of a catwalk block with railings is reflected correctly (i.e. a schematic with a catwalk block with two railings will need one catwalk item and two railing items).
Rotating and mirroring catwalk blocks in schematics works correctly.
Breaking a catwalk block with railings will drop the correct number of catwalk and railing items.
When placing catwalk or railing items into existing blocks, there’s code to make sure that the item and block have a matching metal type.
When the last component of a catwalk block is removed by shift-wrenching, the block will be replaced with an air block.
Railings cannot be placed inside the catwalk block if the catwalk is at the top.
Mechanical deployers can use railings on catwalks.
I’ve tested both the Forge and Fabric version.

Known issues

There are a couple of small things that I couldn’t fix yet. They are all related to ghost states in placement helpers. When holding an item of one metal type and looking at a block of another metal type, there’s still a ghost state presented that hints at a possible interaction. However, actually placing the item into the block doesn’t work. So it’s mostly a cosmetic issue.

Specifically, the following interactions produce ghost states that aren’t accurate:

holding a catwalk item and looking at a catwalk block of a different metal
holding a catwalk item and looking at a railing block of a different metal
holding a railing item and looking at a catwalk block of a different metal

None of the interactions succeed, though.

…esence of catwalk

… stairs This is useful for implementing the interaction between catwalk blocks and railing blocks, where we want to only allow interactions if their metals match.

Placing a catwalk of the same metal on an existing railing block will add the catwalk to the bottom of the railing block.

…nd presence of railings This is an alternative approach where the catwalk block has properties to indicate whether there are railings in the block, and whether there's a catwalk shape at the top or bottom of the block.

…hey're made of

this is taken straight from the CatwalkRailing block code

When wrenching a catwalk block, change the state depending on the current state: - If the catwalk block has any railings, rotate the block using the default iWrenchable implementation - If there are no railing blocks, toggle between the top and bottom surface

…g block" I prefer the approach where the Catwalk block is the main block that contains state for railings, so the changes in this commit are no longer needed.

…esent presence of catwalk" This reverts commit 728c8eefdc5556364a9be6ff22caf89a41d43285 (except for the block andesite_catwalk_down, which we're still using)

…ottom

…tate (top/bottom)

…ials

I've added a second function isCatwalkOrStair that has the old behaviour, but I'm not using it anywhere because I don't yet understand why it permitted both, catwalk blocks and stairs here

I set everything to true for debugging, but realistically, initially we only want a single catwalk.

This tweaks the interaction between catwalks and railing items. A catwalk block that has a top-side catwalk shouldn't allow placing rails inside its block. Those would show up under the catwalk. By preventing this interaction, the railing will simply be placed on the block above.

When placing a catwalk block into an existing railing block, the railing block is replaced by a catwalk block with the appropriate block state set.

…and items The placement helpers still produce ghost states, even if the metals don't match. I haven't been able to figure out why that is.

Before, the item costs in schematics would not accurately represent how many items are actually needed, and you could place a block with 4 railings with only a single railing item. This fixes that by specifying the exact number of items, depending on the block state.

…the top

snailcase · 2025-03-14T23:07:17Z

ah I see that there were some changes in 1.20-main yesterday. I'll resolve the conflicts and test with the new changes tomorrow!

riggyz · 2025-03-15T00:19:23Z

+1 to this!

Conflicts: common/src/main/java/com/github/talrey/createdeco/items/CatwalkBlockItem.java common/src/main/java/com/github/talrey/createdeco/items/RailingBlockItem.java

On 1.7, the build failed with the following error message: * What went wrong: A problem occurred evaluating root project 'createdeco'. > Failed to apply plugin 'dev.architectury.loom'. > Could not create an instance of type net.fabricmc.loom.extension.LoomGradleExtensionImpl. > Could not create an instance of type net.fabricmc.loom.extension.LoomProblemReporter. > 'org.gradle.api.problems.ProblemReporter org.gradle.api.problems.Problems.forNamespace(java.lang.String)' This fix is based on architectury/architectury-api#586

snailcase · 2025-03-15T08:49:24Z

I've pulled in the changes from 1.20-main, and tested everything again with Create v6. All seems to work, still. I did have to update architectury loom to 1.9-snapshot (see 3216860). Not sure if there's a way around that... here's the error that I got with 1.7-SNAPSHOT:
loom-1.7-errors.txt

Bugtester6977 · 2025-11-17T23:28:57Z

Hi, Very late but does this still work and do If I am on a aternos server do i have to type the code into the server.

snailcase added 30 commits March 13, 2025 21:40

Proof of concept: Add block state to catwalk railings to represent pr…

4de2081

…esence of catwalk

Instantiate the catwalk railing block with a metal String, similar to…

7744207

… stairs This is useful for implementing the interaction between catwalk blocks and railing blocks, where we want to only allow interactions if their metals match.

Implement interaction between catwalk item and catwalk railing block

eecd73c

Placing a catwalk of the same metal on an existing railing block will add the catwalk to the bottom of the railing block.

Instantiate catwalk blocks with a string identifying the metal that t…

c3d3ece

…hey're made of

Interact with a shape to return the corresponding block

ace51a3

Clear the block when the last element is sneak-wrenched

510b8d3

Override how block is rotated with wrench

3c09ed3

this is taken straight from the CatwalkRailing block code

Revert "Implement interaction between catwalk item and catwalk railin…

53df6c0

…g block" I prefer the approach where the Catwalk block is the main block that contains state for railings, so the changes in this commit are no longer needed.

Revert "Proof of concept: Add block state to catwalk railings to repr…

4d7627c

…esent presence of catwalk" This reverts commit 728c8eefdc5556364a9be6ff22caf89a41d43285 (except for the block andesite_catwalk_down, which we're still using)

Rename the CatwalkHelper to hint that it's used for extending catwalks

cef411a

Add function to check if catwalk block has any catwalks in its state

27e5ec2

Using a catwalk item on a catwalk block will place a catwalk on the b…

c6494e2

…ottom

When extending a catwalk block, clear railings and copy the catwalk s…

65bebd4

…tate (top/bottom)

Limit interaction between catwalks and railing item to the same mater…

2cd9004

…ials

Only check for CatwalkBlock when checking if something isCatwalk

322d32f

I've added a second function isCatwalkOrStair that has the old behaviour, but I'm not using it anywhere because I don't yet understand why it permitted both, catwalk blocks and stairs here

Update loot table for catwalks to drop railings

da22d58

Add config to generate block states for catwalks

e9573e2

Add generated blockstates and models

8e2edb5

Fix initial state of block properties

59fa5ab

I set everything to true for debugging, but realistically, initially we only want a single catwalk.

Remove debug output

89aebf2

Replace railing block with catwalk block seamlessly

4c47463

When placing a catwalk block into an existing railing block, the railing block is replaced by a catwalk block with the appropriate block state set.

Check for same metal in interactions between rail and catwalk blocks …

e7c5df7

…and items The placement helpers still produce ghost states, even if the metals don't match. I haven't been able to figure out why that is.

Change default initial catwalk position to top

ae5ae41

Implement mirroring and rotation for catwalk block

186211c

When extending catwalks, also check for the same metal type

e320b49

When checking if block is supported, also check if the catwalk is at …

ea00b30

…the top

snailcase changed the title ~~Catwalks overhaul~~ Proposal to reintroduce catwalks at the bottom of the block Mar 14, 2025

snailcase added 3 commits March 15, 2025 08:58

Merge branch '1.20-main' into catwalks-overhaul

3cf9ea8

Conflicts: common/src/main/java/com/github/talrey/createdeco/items/CatwalkBlockItem.java common/src/main/java/com/github/talrey/createdeco/items/RailingBlockItem.java

Fix incompatibilities with Create v6

73ff5f3

snailcase marked this pull request as ready for review March 15, 2025 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Proposal to reintroduce catwalks at the bottom of the block #193

Proposal to reintroduce catwalks at the bottom of the block #193

Uh oh!

snailcase commented Mar 14, 2025

Uh oh!

snailcase commented Mar 14, 2025

Uh oh!

riggyz commented Mar 15, 2025

Uh oh!

snailcase commented Mar 15, 2025 •

edited

Loading

Uh oh!

Bugtester6977 commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Proposal to reintroduce catwalks at the bottom of the block #193

Are you sure you want to change the base?

Proposal to reintroduce catwalks at the bottom of the block #193

Uh oh!

Conversation

snailcase commented Mar 14, 2025

Overview of changes

Placing Catwalks

Placing Railings

Interacting with catwalk blocks

Interacting with railing blocks

Things I’ve tested

Known issues

Uh oh!

snailcase commented Mar 14, 2025

Uh oh!

riggyz commented Mar 15, 2025

Uh oh!

snailcase commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bugtester6977 commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

snailcase commented Mar 15, 2025 •

edited

Loading