-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix container names with hyphens #17628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -777,4 +777,10 @@ function* findRoots(input: string, exists: (input: string) => boolean): Iterable | |
|
||
idx = input.lastIndexOf('-', idx - 1) | ||
} while (idx > 0) | ||
|
||
// Try '@' variant after permutations. This allows things like `@max` of `@max-foo-bar` | ||
// to match before looking for `@`. | ||
if (input[0] === '@' && exists('@')) { | ||
yield ['@', input.slice(1)] | ||
} | ||
Comment on lines
+773
to
+777
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've been thinking of restructuring this somehow so that there's only one special-case for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I was thinking that there would probably be some way to have only one code path for |
||
} |
Uh oh!
There was an error while loading. Please reload this page.