Fix crash in Combobox component when in virtual mode when options are empty
#3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
Combobox component when in virtual mode without available optionsCombobox component when in virtual mode when options are empty
RobinMalfait
force-pushed
the
fix/issue-3353
branch
from
dc80642 to
eec1861
Compare
Contributor
|
I wasn't able to repro this originally but based on the fix in tanstack it was timing related so I think this is fine to merge 👍 |
thecrypticace
approved these changes
Jul 2, 2024
Member
Author
|
I could reproduce it locally a few times, but not consistently. However when I switch to the fixed branch (this one) I couldn't reproduce it anymore. When I switch back and try a few times I could reproduce it again. |
|
thank you so much @RobinMalfait! |
This was referenced Jul 27, 2024
This was referenced Aug 15, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 18, 2024
Closed
1 task
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where using
@tanstack/react-virtualwith an empty array could lead to crashes such as:Providing an empty array can happen if you filter the options based on the value of the
ComboboxInput.This PR fixes that by bumping the
@tanstack/react-virtuallibrary and using theenabledvalue and disable it when no options are given.Fixes: #3353