feat(rawdb): introduce batchToBlock mapping

[davidtaikocha]

In Shasta fork, we can't know the last block ID in a batch / proposal anymore, so the node has to record it by itself.

[claude]

Claude finished @davidtaikocha's task —— View job

---

Pull Request Review

Reviewing PR #447: feat(rawdb): introduce batchToBlock mapping

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze changed files and understand the implementation
• Review code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage
• Provide comprehensive feedback

---

Code Review Summary

This PR introduces a database mapping from batch ID to block ID to track the last block in each batch/proposal for the Shasta fork. The implementation is well-structured and follows existing patterns in the codebase.

Code Quality Assessment

Strengths:

• Follows existing Taiko naming conventions (taiko_*.go, CHANGE(taiko): comments)
• Consistent with existing database key patterns and serialization methods
• Proper error handling and logging throughout
• Clear function documentation and parameter validation

Areas for improvement:

• Typo in variable name on line 18 of core/rawdb/taiko_l1_origin.go

Detailed File Analysis

1. beacon/engine/types.go and gen_blockmetadata.go

Lines 75-76: Addition of BatchID *big.Int field to BlockMetadata struct

• ✅ Correctly implemented as optional field with proper JSON marshaling
• ✅ Generated code properly handles nil checks and validation

2. core/rawdb/taiko_l1_origin.go

Lines 18, 29-34, 134-156: Core batch-to-block mapping implementation

Issue Found:

• Line 18: Typo in variable name: batchToBlockPrefixy should be batchToBlockPrefix

Positive aspects:

• ✅ Follows existing patterns for database keys and serialization
• ✅ Proper use of math.HexOrDecimal256 for consistent encoding
• ✅ Error handling with appropriate logging using log.Crit and log.Error
• ✅ Function signatures match existing conventions

3. eth/catalyst/api.go

Lines 518-522: Integration with payload building

Code Quality:

• ✅ Proper conditional logic - only writes mapping for non-preconfirmation blocks
• ✅ Null check for BatchID before writing mapping
• ✅ Follows existing L1Origin writing pattern

4. eth/taiko_api_backend.go

Lines 63-73: New API method for batch-to-block lookup

Implementation Quality:

• ✅ Proper error handling with ethereum.NotFound for missing data
• ✅ Leverages existing L1OriginByID method to avoid code duplication
• ✅ Consistent parameter types with other API methods

Security Assessment

• ✅ No user input validation issues - uses internal database operations
• ✅ Proper error handling prevents information leakage
• ✅ Database keys use consistent prefixing to avoid collisions
• ✅ Write operations are properly scoped to authenticated contexts

Performance Considerations

• ✅ Database operations use existing efficient key-value patterns
• ✅ Minimal overhead - only adds mapping when BatchID is present
• ✅ Leverages existing serialization mechanisms
• ✅ Read operations are O(1) lookups

Test Coverage Gap

Missing Tests:
The PR lacks test coverage for the new functionality. Consider adding tests for:

• WriteBatchToBlock and ReadBatchToBlock functions
• L1OriginByBatchID API method
• Error cases (missing batch ID, invalid data)
• Integration test for the full batch-to-block flow

Recommendations

1. Fix typo: Change batchToBlockPrefixy to batchToBlockPrefix in core/rawdb/taiko_l1_origin.go:18

2. Add test coverage: Implement unit tests for the new database functions and API methods

3. Consider documentation: Add a comment explaining the purpose of the batch-to-block mapping for future maintainers

Overall Assessment

The implementation is well-designed and safe to merge after addressing the typo. The code follows existing patterns, includes proper error handling, and integrates cleanly with the existing Taiko-specific modifications. The lack of tests is the main concern, but doesn't block functionality.

Approval Status: ✅ Approve with minor fix