feat: allow downloading martin and martin-cp
#1075
Conversation
|
With the current this PR, martin-cp is likely not be installed. For multiple binaries, I think it is necessary to use the same way as wasm-bindgen. |
tools/codegen/base/mbtiles.json
Outdated
| "repository": "https://github.com/maplibre/martin", | ||
| "tag_prefix": "v", | ||
| "rust_crate": "mbtiles", | ||
| "asset_name": "martin-${rust_target}", | ||
| "version_range": ">= 0.11.0", |
There was a problem hiding this comment.
mbtiles is included in the martin release archive and since the martin release archive is released based on the martin version, so specifying the rust_crate here does not work correctly. This is because the release version number is not matched with the actual crate version of mbtiles.
I would suggest including mbtiles in martin's binary list as with martin-cp.
There was a problem hiding this comment.
yea, our releases are too messy for automated tooling on this one.
rust_crate: mbtiles and the github releases under a different version number (lol)
We should split mbtiles into their own releases and then I can open another PR for this.
CommanderStorm
changed the title
martin, martin-cp and mbtilesmartin and martin-cp
|
I am having trouble to make the paths on windows behave. I will need to look into the code which paths precicely |
Sorry to bother you again.
Repo: https://github.com/maplibre/martin
Example release: https://github.com/maplibre/martin/releases/tag/v0.18.0
martin/martin-cpis relatively straightforward to package. It is just one crate with two binaries.mbtileson the otherhand is a tad bit weird given that it is included in the release-zip of martin, but this is likely still fine.