[Enhancement] Adding AWS as a provider to the models #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current models file contains only OpenAI and Azure authentication. Adding AWS auth allows users to select from wide range of models available on Bedrock
|
Thanks for the contribution! Before we can merge this, we need @abhi9cr7 to sign the Salesforce Inc. Contributor License Agreement. |
abhi9cr7
changed the title
|
@joeconstantino @stephenlprice I am not sure who from Tableau needs to review this PR. Can you please review this PR, or tag appropriate people? |
allisonbierschenk
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR Title: AWS support
Author: Abhi G
Date of Review: August 9th 2025
Summary
Current
models.pyfile contains only OpenAI and Azure authentication. This pull request adds AWS auth allows users to select from wide range of models available on Bedrock.Functionality & Implementation:
langchain-awsto the requirementsOpenAIas the default provider in the experimental folder to make sure current tests do not failmodels.pyto useChatBedrockConverseandBedrockEmbeddingsifAWSis passed as the model providerAWS Profilefrom an AWS credential file, orAccess Key, Secret & Tokens