Allow multiple class names on buttons

[krvajal]

This pull request allows the use of multiple class names when passing the className options to the button. The different classes should be separated by spaces.

[wutmikee]

Is this getting pushed?

[pbarbiero]

+ buttonEl.classList.add(className);

Shouldnt that be

+ buttonEl.classList.add(className_);

Also, @t4t5 it would be great if we could get this feature added. It'd also be nice if we could exclude the swal--button class as well so we dont have to reset it if we are overhauling the button design.

[lionralfs]

Thanks for the PR, @krvajal

I went ahead and added the possibility to also pass an array of classNames, as discussed in #743,
as well as some tests.

Looks good @t4t5?

[krvajal]

Please take a look a the suggested changes, as I am not a maintainer of the project you are not required to follow them but it will be nice to do :)

[krvajal]

Please check the length of the name here, and also DRY when adding the class names. In both cases, we get an array from the input, so you could instead do this

const classNameArray = Array.isArray(className)? className: className.split(' ')
classNameArray.forEach(name => {
buttonEl.classList.add(name);
});

Makes sense?

[lionralfs]

Sure, great idea.
Do you agree with this?

const classNameArray = Array.isArray(className) ? className : className.split(' ');
classNameArray
  .filter(name => name.length > 0)
  .forEach(name => {
    buttonEl.classList.add(name);
  });

[krvajal]

The first line can be split into parts for clarity if you want but yes, that's the idea.

[krvajal]

@t4t5 are you considering adding this?

[bahirul]

please merge this ... we need this feature 👍

[t4t5]

Looks great guys! Thanks for the work @krvajal @lionralfs!