Remove stats schema name from the query in stats user session

[wazir-ahmed]

Closes #4509

[gemini-code-assist]

Summary of Changes

Hello @wazir-ahmed, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where queries in the stats user session might contain an explicit stats schema prefix, which could lead to incorrect parsing or execution. It introduces a robust utility function to dynamically strip this schema prefix from incoming queries, ensuring that only the table name is used. This change improves the flexibility and correctness of query handling within the stats context, making the system more resilient to variations in query formatting.

Highlights

• New Utility Function: Introduced a new C++ utility function, strip_schema_from_query, designed to remove a specified schema prefix (e.g., stats.) from SQL query strings.
• Query Modification in Stats Session: Queries executed within the stats user session are now pre-processed by strip_schema_from_query to automatically remove the stats schema name from table references, ensuring queries are correctly interpreted without explicit schema qualification.
• Robust SQL Parsing: The strip_schema_from_query function includes logic to handle various SQL parsing complexities, such as identifying and skipping schema names that appear within string literals, and correctly parsing both unquoted and quoted identifiers (using backticks or double quotes, depending on ansi_quotes mode).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sonarqubecloud]

Quality Gate failed

Failed conditions
3 Security Hotspots
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[gemini-code-assist]

Code Review

This pull request introduces a new utility function strip_schema_from_query to remove schema prefixes from SQL queries, which is then utilized in the admin handler for stats user sessions. This change allows queries against the stats tables to be made without the stats. prefix. The implementation of the new function is thorough, correctly handling string literals and quoted identifiers. The changes are well-contained and effectively achieve the intended goal. I have added a couple of suggestions in lib/gen_utils.cpp to enhance code clarity and adhere to C++ best practices. Overall, this is a solid contribution.