Skip to content

Conversation

Confushion
Copy link

Setting "information_schema_stats_expiry" blocks mysql_query_rules changing hostgroup routing.

https://dev.mysql.com/doc/refman/8.4/en/server-system-variables.html#sysvar_information_schema_stats_expiry

This change includes "information_schema_stats_expiry" as a known setting.

Setting "information_schema_stats_expiry" blocks mysql_query_rules changing hostgroup routing.

https://dev.mysql.com/doc/refman/8.4/en/server-system-variables.html#sysvar_information_schema_stats_expiry

This change includes "information_schema_stats_expiry" as a known setting.

Signed-off-by: Menno van Gangelen <[email protected]>
Copy link

Summary of Changes

Hello @Confushion, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the 'information_schema_stats_expiry' MySQL system variable into the application's recognized settings. This is a critical update to ensure that the application correctly handles this variable, thereby resolving an issue where its presence could interfere with hostgroup routing rules. The change improves the system's compatibility and stability when interacting with MySQL instances configured with this specific setting.

Highlights

  • New MySQL Setting Recognition: The pull request adds 'information_schema_stats_expiry' to the list of known numeric MySQL variables within the application.
  • Resolving Routing Interference: By recognizing this setting, the change aims to prevent it from blocking 'mysql_query_rules' from correctly changing hostgroup routing, as noted in the MySQL documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and resolves an issue where the information_schema_stats_expiry setting could block hostgroup routing changes. By adding this variable to the mysql_variables_numeric set, it is now recognized as a known numeric variable, preventing it from being flagged as an unknown variable that would lock a session to a specific hostgroup. The change is simple, correct, and maintains the alphabetical order of the list for better readability. This is a good fix.

@renecannao
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants