Circular dependency any.js -> pseudo.js -> any.js using rollup

[peterbabic]

Circular dependency any.js -> pseudo.js -> any.js using rollup

The rollup bundler is printing warnings about the detected circular dependency:

Circular dependency: node_modules/unist-util-select/lib/any.js -> node_modules/unist-util-select/lib/pseudo.js -> node_modules/unist-util-select/lib/any.js
Circular dependency: node_modules/unist-util-select/lib/any.js -> node_modules/unist-util-select/lib/pseudo.js -> /home/delmadord/work/sapper-blog/node_modules/unist-util-select/lib/any.js?commonjs-proxy -> node_modules/unist-util-select/lib/any.js

I will provide MVE to reproduce as soon as confirmed it is necessary. I may be mistaken of course, but from what I believe right now, any code analysis tool that would check for circular dependency issues should be able to spot this, not just rollup.

Lines that I believe lead to this behavior:

unist-util-select/lib/any.js

Line 6 in 2269b1c

var pseudo = require('./pseudo')

unist-util-select/lib/pseudo.js

Line 8 in 2269b1c

var anything = require('./any')

Thank you for your work

[wooorm]

You're probably right! PR welcome to change it!

[peterbabic]

Would you agree with an approach to merge both files (pseudo.js and any.js) into one file, so they do not need to reference each other? This is the first thing that comes to my mind

[wooorm]

Hmm, they’re rather separate things.
A different approach which I think I like more: only needsIndex is used:

unist-util-select/lib/pseudo.js

Line 12 in 2269b1c

match.needsIndex = [

. How about moving that to a new, third file?

[peterbabic]

Too bad
peterbabic@ea7f88f

Before:

After:

Images generated with

npx madge --image graph.png index.js

[wooorm]

oh interesting, and nice graph 😅
How about instead passing any in the context objects here and using it in all places that used to require it?

[peterbabic]

Instructions unclear - rg context returned no output

Please elaborate further 😇

[wooorm]

I meant that the third param is an object which is passed to most functions as the third param, so placing any in it means all functions can access it

[peterbabic]

Well, it works, tests passing

peterbabic@50ae64e

[peterbabic]

Also, to reduce complexity further, I believe needsIndex moved into needs.js could be safely moved into nest.js or test.js looking at graphs

EDIT:
moved to any.js because it is the sole consumer of the array

peterbabic@2e09516

[peterbabic]

I have made another branch with a single commit only applying the approach 2
peterbabic@375cdfe

The cyclic dependency is indeed resolved