Skip to content

fix: remove preceding -Xcc instead of the argument following -Werror or -Wwarning #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove preceding -Xcc instead of the argument following -Werror or -Wwarning #9194

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3168b15
fix: remove preceding `-Xcc` instead of the argument following `-Werr…
Sep 26, 2025
91f2587
refactor: use simple for loop instead of filter with side-effect closure
Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Build/BuildDescription/SwiftModuleBuildDescription.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ public final class SwiftModuleBuildDescription {
if self.package.isRemote {
// suppress-warnings and the other warning control flags are mutually exclusive
var removeNextArg = false
args = args.filter { arg in
args = Array(args.lazy.reversed().filter { arg in
if removeNextArg {
removeNextArg = false
return false
Expand All @@ -626,7 +626,7 @@ public final class SwiftModuleBuildDescription {
default:
return true
}
}
}.reversed())
guard !removeNextArg else {
throw InternalError("Unexpected '-Wwarning' or '-Werror' at the end of args")
}
Expand Down