Fix test output streaming on Windows #9191
Open
+71
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
bkhouri,
cmcgee1024,
daveyc123 and
rconnell9
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Sep 26, 2025
owenv
force-pushed
the
windows-streaming
branch
from
95a8c1c to
1226c88
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
cmcgee1024
approved these changes
Sep 26, 2025
dschaefer2
reviewed
Sep 26, 2025
|
This is fine, it's all non-blocking through Dispatch. |
owenv
force-pushed
the
windows-streaming
branch
from
1226c88 to
39c51cf
Compare
|
@swift-ci test |
owenv
force-pushed
the
windows-streaming
branch
from
39c51cf to
c2dd0c0
Compare
|
@swift-ci test |
|
@swift-ci please test windows |
owenv
force-pushed
the
windows-streaming
branch
from
c2dd0c0 to
3483f59
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
rconnell9
reviewed
Oct 1, 2025
| while !Task.isCancelled { | ||
| let chunk = try await readChunk(upToLength: 4096) | ||
| if chunk.isEmpty { | ||
| return nil |
There was a problem hiding this comment.
Should this be a continuation (e.g. cont.finish() here)? I'm not sure what the implications are of returning nil are for clients of this stream.
There was a problem hiding this comment.
returning nil here is intended to terminate the stream, this initializer doesn't use a continuation
owenv
force-pushed
the
windows-streaming
branch
from
3483f59 to
f153b91
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
owenv
force-pushed
the
windows-streaming
branch
from
f153b91 to
7c818d8
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncProcess implementation on Windows was effectively buffering all output until process exit. Vendor over some utilities from Swift Build to stream the output, and attempt to avoid the bug addressed in #8047 (review)