Remove redundant "bundle" parameters where a context is also available #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.referencesForSymbols
|
@swift-ci please test |
d-ronnqvist
force-pushed
the
remove-redundant-bundle-params
branch
from
9283b45 to
1cfcdd0
Compare
|
@swift-ci please test |
…onContext methods
d-ronnqvist
force-pushed
the
remove-redundant-bundle-params
branch
from
1cfcdd0 to
299719a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
Now that DocumentationContext is known have exactly one inputs/bundle, types and methods don't need both a context parameter and a inputs/bundle parameter.
This PR goes through various types one-by-one and removes the bundle parameters and updates all the callers to stop passing it.
The main benefit of this is that it's no longer possible to pass a bundle/inputs that don't belong to the context.
Another outcome of this is that many tests who call the context loading test helpers now ignore the bundle. A follow up PR, after this is merged, will clean up the test helpers and have the caller access the bundle/inputs from the context where needed.
Dependencies
None.
Testing
Nothing in particular. This isn't a user-facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded[ ] Updated documentation if necessary