Skip to content

Full integration with test pane #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rpedretti
Copy link

@rpedretti rpedretti commented Nov 4, 2024

This PR adds:

  • Read the test plan for the test build scheme and add to test explorer
  • Handle file change, creation and deletion to update the test explorer
  • Fix the commands to run the tests
  • The load should handle both SPM and non-SPM since the tests are reading from the test plan
  • Remove overall test result since we update all from logs

This pr fixes:

  • Getting code blocks from class

To do:

  • Mark tests as skipped if they are skipped on test plan

@hyzyla
Copy link
Collaborator

hyzyla commented Nov 4, 2024

😍 thanks for this pr. I need some time to review and test all changes, but at the first glance looks pretty good

@cameroncooke
Copy link

Any movement on this?

@bryan1anderson
Copy link

Where is this at.. can we get it merged if we fix the conflicts?

@BlackWolf
Copy link
Contributor

@hyzyla I am currently also looking into testing improvements, would be good to know what the plan is with this PR. I think it's a good approach and would be nice to get it merged, but I think we need to combine it with other approaches. I tested it with a complex project of mine with multiple targets, SPM modules, etc. and it didn't detect the tests properly. I can look into it if it can be fixed, but I think it's because autocreated test plans are not saved to disk and we cannot read them in this way.

I am currently looking into an approach using xcodebuild --enumerate-tests, maybe combining both makes sense. I think it will take a bit until I have something mergeable, but I'm just not sure if I should open a second PR about tests now or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants