Skip to content

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 6, 2025

Description:

This is required to generate a sourcemap when multiple modules are merged but they are using different swc_common::SourceMap

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone May 6, 2025
@kdy1 kdy1 self-assigned this May 6, 2025
@kdy1 kdy1 requested a review from a team as a code owner May 6, 2025 17:33
kodiakhq[bot]
kodiakhq bot previously approved these changes May 6, 2025
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: a954514

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) May 6, 2025 17:34
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Performance Report

Merging #10438 will degrade performances by 2.14%

Comparing kdy1/srcmap-abs (a954514) with main (164cbaa)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
deserialization of serde 2.4 µs 2.4 µs +2.46%
serialization of serde 2.7 µs 2.7 µs -2.14%

@kdy1 kdy1 disabled auto-merge May 6, 2025 20:13
@kdy1 kdy1 merged commit 2a07c8a into main May 6, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/srcmap-abs branch May 6, 2025 20:13
kdy1 added a commit to vercel/next.js that referenced this pull request May 7, 2025
### What?

Update swc_core to the latest version

### Why?

Apply swc-project/swc#10438: Add `swc_core::common::build_sourcemap` which can be used to generate sourcemap from multiple `SourceMap` instances.
@kdy1 kdy1 modified the milestones: Planned, v1.11.26 May 12, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant