feat: add wnba live endpoint #555
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added boxscore endpoint for Live WNBA data.
My initial approach was to simply create a new WNBALiveHTTP class and switch which LiveNBAHTTP class to use (in the existing endpoint) based on gameID, but this seemed to conflict with the pattern used in the rest of the repo. Another issue with my initial approach is that there would be an inconsistency with the Scoreboard endpoint which does not rely on a gameId, unless we required a league parameter be passed in.
Instead, I created a new endpoint within a wnba package. I added only the boxscore endpoint to start, for approval on this design. I'm also happy to switch back to the initial approach or discuss on this.
Please let me know if I missed anything!