swan-cern: filter the free gpu display in case of concurrent session request #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etejedor
reviewed
Aug 10, 2025
| free_flavours = list(spawner.gpus.get_free_gpu_flavours().keys()) | ||
|
|
||
| if spawner.LHCB_SWAN_ROLE in spawner.user_roles: | ||
| free_flavours = list(spawner.gpus.get_free_lhcb_gpu_flavours().keys()) |
There was a problem hiding this comment.
I think I would be slightly in favour of pushing this down to the get_free_gpu method, perhaps by parameterizing it to make it receive the user roles. The get_free_gpu method should be the brains and hide this complexity from its callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.