Support empty string as default value in the struct field #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdghchj
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR handles the issue with the
defaulttag in the struct field. The tool ignores the empty string value for thedefaulttag while generating the swagger specification.The reason behind it is how the value for the
defaulttag is being read. The code was using thetag.Get()method. This method could return an empty string in two cases: the value itself is an empty string, or the tag doesn't exist at all. And the condition below doesn't handle the first case correctly.I have changed it to use the
tag.Lookup()method to distinguish between the two cases and changed the condition accordingly.Relation issue
#2052