[PYTHON] Issue 8075 - additionalProperties support #8414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2018 14:27
…al properties of models with additionalProperties defined.
Author
ivan-gomes
changed the title
| isinstance(data, (list, dict))): | ||
| value = data[klass.attribute_map[attr]] | ||
| kwargs[attr] = self.__deserialize(value, attr_type) | ||
|
|
Contributor
There was a problem hiding this comment.
file permissions should stay at 0644
| {{import}} # noqa: F401,E501 | ||
| {{/imports}} | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
file permissions should stay at 0644
Contributor
|
Minor revert of the file permissions. Otherwise it LGTM. Thanks! @ivan-gomes |
Author
|
Reverted the file permissions. Good catch! Thanks. |
Contributor
|
after reviewing and test locally (merging upstream master into Thanks a lot @ivan-gomes !!! |
Contributor
|
it seems my verification was not ok since build is failing for python, anyway i'll check if it's something i can fix, otherwise i'll file a new issue. |
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes #8075.