Skip to content

Conversation

skrysm
Copy link
Contributor

@skrysm skrysm commented Feb 9, 2019

This fixes the problem that the vendor extension x-has-more doesn't work properly for request bodies.

The reason is that the same bodyParam instance is added to both the bodyParams and the allParams collection. Then, later this is done:

codegenOperation.allParams = addHasMore(allParams);
codegenOperation.bodyParams = addHasMore(bodyParams);

The second line will set the vendor extension x-has-more to false for the last body param - even if it's not the last param in allParams. And that's wrong.

@skrysm
Copy link
Contributor Author

skrysm commented Feb 9, 2019

I'm closing this because pull request #298 is way more comprehensive and fixes the same problem.

@skrysm skrysm closed this Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant