feat: remote files can now be in your kit.alias locations #14096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f614425 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jycouet
commented
Aug 3, 2025
Comment on lines
483
to
495
| // TODO could files live in other directories, including node_modules? | ||
| for (const dir of [config.kit.files.lib, config.kit.files.routes]) { | ||
| const directories = [ | ||
| config.kit.files.lib, | ||
| config.kit.files.routes | ||
| ]; | ||
|
|
||
| // Add alias directories | ||
| for (const [, alias_path] of Object.entries(config.kit.alias)) { | ||
| const resolved_path = path.resolve(cwd, alias_path); | ||
| if (fs.existsSync(resolved_path)) { | ||
| directories.push(resolved_path); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe with alias you can 'opt-in' to something in your node_modules ?
jycouet
commented
Aug 3, 2025
Comment on lines
22
to
25
|
|
||
| // Allow remote functions to be imported on the client side (they get transformed) | ||
| if (REMOTE_FILE_PATTERN.test(path.basename(id))) return false; | ||
|
|
There was a problem hiding this comment.
I didn't find how lib and routes are doing this!
I'm probably missing something!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could address #14077
Feel free to disagree.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits