Skip to content

fix: removes group segment from route id to allow correct resolution of urls #14064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hawk93
Copy link

@hawk93 hawk93 commented Jul 27, 2025

closes #14062


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 27, 2025

🦋 Changeset detected

Latest commit: ecdb16f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@eltigerchino
Copy link
Member

Thanks for the PR! A changeset is needed for patch fixes like this one.

@PatrickG
Copy link
Member

I'm not sure if this should be merged, see my comment in the issue.

@Rich-Harris
Copy link
Member

Agree with @PatrickG — you can either pass a RouteId or a Pathname. I think it's better to enforce this throughout, rather than allowing either of those or a secret third option, because you will end up with inconsistencies in your app otherwise.

For completeness: if we were to do this the logic would need tweaking — it only adds de-grouped route IDs for dynamic routes, and doesn't e.g. add /blah for /(group)/blah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve problems with (group) folder
4 participants