feat(cli): sv add --no-git-check

[jycouet]

Closes #240

I've set changeset to minor as a flag is removed. (Not sure if it's really minor, could be patch also)

[changeset-bot]

🦋 Changeset detected

Latest commit: 6108cbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sv	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svelte-docs-bot]

Preview: https://svelte-dev-git-preview-cli-650-svelte.vercel.app/

[pkg-pr-new]

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@650

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@650

commit: 6108cbe

[manuel3108]

Will need to check this in details another time, but makes sense at a first glance.
Also minor totally makes sense here, as I know a few people actually using the cli args to generate one off projects.

[manuel3108]

I do think this broke something.
pnpm create vite && pnpx https://pkg.pr.new/sveltejs/cli/sv@650 add drizzle runs successfully for some reason, even it shouldn't.

Also I think in general we should take it one step further and completely get rid of the word preconditions in the user facing cli portion. But we can (and probably should) do that in a follow-up pr

[jycouet]

I do think this broke something. pnpm create vite && pnpx https://pkg.pr.new/sveltejs/cli/sv@650 add drizzle runs successfully for some reason, even it shouldn't.

I just tried and got:

[manuel3108]

You are right, I was in a nested svelte-kit application, in which case what I saw even makes sense. Can confirm it's working as expected.

[manuel3108]

Thank you!

If you want, I think there is even further potential for improvement. Like why is the unsupported check even part of the verifications, if it always throws on fails and the catch is located somewhere else?

As you said in the issue, the unsupported check is not optional, it's a must that it passes. The git check is a can / should.

Should we totally get rid of the concept of verifications in the next step? And check both things independently?

[hyunbinseo]

I've been using --no-preconditions and would like to migrate:

https://github.com/hyunbinseo/svelte-kit-templates/blob/v0.8.21/index.js#L24

Is it a simple rename? If so, specifying this in the change-log would be helpful

The current preconditions is a check to see if you have a dirty git repo #240 (comment)

[manuel3108]

It's a bit more, but in your case you can treat it as a rename.

The other check we are currently doing is that you cannot add an addon that does not support pure svelte apps (like drizzle) to a pure svelte app (without kit).

But I don't think that matters in your example.