Fix for #20, enable multiple navbars on a page #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le navbars on a page NOTE: MAJOR breaking change: CloseOnClick is now on MenuIcon NOTE2: Code formatting is wrong, would be nice if you could reformat the code before merging to minimy changes DISCUSSION: As the script is inline, it would be better to move to MenuIcon.astro and get rid of Astronav.astro. The closeOnClick makes sense to be on the Menu button itself, so seems fine for me
|
Thanks for the PR, I'm on a vacation now. will check and merge later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose fix for #20, enable the possibility to have multiple navbars on a page
NOTE: MAJOR breaking change: CloseOnClick is now on MenuIcon
NOTE2: Code formatting is wrong, would be nice if you could reformat the code before merging to minimy changes
DISCUSSION:
As the script is inline, it would be better to move to MenuIcon.astro and get rid of Astronav.astro. The closeOnClick makes sense to be on the Menu button itself, so seems fine for me