Skip to content

Conversation

deepjyoti30-st
Copy link
Contributor

@deepjyoti30-st deepjyoti30-st commented Jun 10, 2025

Summary of change

This PR achieves a few things:

  • Ensures that if domain/path validation fails then the correct error is thrown
  • Gets rid of react-native-url-polyfill and moves to using the native implementation
  • Updates some dependencies to ensure they can be installed on a fresh repo.

Related issues

Test Plan

All tests should pass

Screenshot 2025-06-11 at 3 02 59 PM Screenshot 2025-06-11 at 3 03 11 PM

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • Ensuring that tests are passing - couldn't get them to run on my local due to various conflicts with the entire setup

Copy link

github-actions bot commented Jun 10, 2025

size-limit report 📦

Path Size
lib/build/index.js 9.5 KB (-64.12% 🔽)

@deepjyoti30-st deepjyoti30-st marked this pull request as ready for review June 11, 2025 09:37
@deepjyoti30-st deepjyoti30-st requested a review from porcellus June 11, 2025 09:37
@iffa
Copy link

iffa commented Jul 19, 2025

Would love to see this PR merged and released soon 🙏🏼

@porcellus porcellus merged commit 9ebb402 into 5.1 Jul 22, 2025
7 checks passed
@porcellus porcellus deleted the fix/dependency-mismatch branch July 22, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants