Skip to content

Conversation

@swills
Copy link

@swills swills commented May 27, 2025

No description provided.

@swills swills marked this pull request as ready for review May 28, 2025 17:13
@swills swills requested a review from supermerill as a code owner May 28, 2025 17:13
@swills swills changed the title WIP support for FreeBSD Support for FreeBSD May 28, 2025
@swills swills mentioned this pull request Jul 7, 2025
@RealDeuce
Copy link

I did have to uninstall graphics/nanosvg to build... but oddly, I didn't need to do anything with nanosvg on my port. I wonder if that's all not actually needed? Alternatively, maybe I did something sneaky to my system and forgot about it.

Also, on mine, I just used libusb/hid.c which built and worked fine, so maybe the new hid.c isn't needed either?

Neither of those are actual problems though, just possibly doing more than is necessary. With the additional changes in my PR to your source branch, it builds and runs correctly here.

@swills
Copy link
Author

swills commented Jul 14, 2025

I did have to uninstall graphics/nanosvg to build... but oddly, I didn't need to do anything with nanosvg on my port. I wonder if that's all not actually needed? Alternatively, maybe I did something sneaky to my system and forgot about it.

Also, on mine, I just used libusb/hid.c which built and worked fine, so maybe the new hid.c isn't needed either?

Hmm, for me, it didn't work. I wonder if it's because I was using -CURRENT?

Neither of those are actual problems though, just possibly doing more than is necessary.

True, but we should minimize changes if possible, I think.

With the additional changes in my PR to your source branch, it builds and runs correctly here.

Should we pull those additional changes in here?

@RealDeuce
Copy link

Should we pull those additional changes in here?

Yeah, that was my thought (the PR is against your source branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants