fly logs: use Flaps client GetLogs to fetch recent logs #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
This PR changes
fly logsto fetch recent log lines directly from a new Machines API (flaps) endpoint instead of through calls to the centralized app-logs service. This should help reduce latency (both query and ingestion latency, so recent logs will show up quicker), and improve the overall reliability offly logscommand (since it doesn't depend on the availability of a centralized log service.How:
Replaces the
flyutil.Clientcall toGetAppLogs()with aflapsutil.flapsClientcall toGetLogs()in the (non-nats)pollimplementation of the log streaming interface.Related to:
Documentation