Skip to content

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

improves error handling on join by doing basic checks on types received by realtime. it's the scafold for future validations with more informative errors to the users

Copy link

vercel bot commented Aug 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
realtime-demo Ignored Ignored Preview Aug 29, 2025 0:03am

@coveralls
Copy link

coveralls commented Aug 21, 2025

Coverage Status

coverage: 84.137% (-0.3%) from 84.391%
when pulling 76a09c5 on fix/join-payload-validation
into 9daf263 on main.

@filipecabaco filipecabaco force-pushed the fix/join-payload-validation branch from ac507f5 to 8e8c562 Compare August 21, 2025 16:48
Copy link
Member

@edgurgel edgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@filipecabaco filipecabaco force-pushed the fix/join-payload-validation branch 2 times, most recently from 1a9927b to cfb3167 Compare August 25, 2025 12:41
@filipecabaco filipecabaco force-pushed the fix/join-payload-validation branch from 4cda35b to 1d140af Compare August 27, 2025 23:28
@filipecabaco filipecabaco force-pushed the fix/join-payload-validation branch 2 times, most recently from 9150381 to f6d0415 Compare August 28, 2025 17:00
improves error handling on join by doing basic checks on types received by realtime. it's the scafold for future validations with more informative errors to the users
@filipecabaco filipecabaco force-pushed the fix/join-payload-validation branch from f6d0415 to 76a09c5 Compare August 29, 2025 12:03
@filipecabaco filipecabaco merged commit b500a58 into main Aug 29, 2025
5 checks passed
@filipecabaco filipecabaco deleted the fix/join-payload-validation branch August 29, 2025 12:16
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.45.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants