stricter EmailSignUpConfirmation deserialization #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raflos10
had a problem deploying
to
test-environment
GitHub Actions
Failure
|
I have a sneaking suspicion there may be conditions where there are optional fields in the response, such as cases when a user signs up without a phone number and thus there is no phone to populate the field. I don't know all the possible permutations of the response, but if you want to do some manual testing to verify which fields we can tighten up that would certainly be welcome! UPDATE: After some manual testing this seems to work fine, so I'll merge. Thank you again for helping out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Due to an update I made a while ago, errors received from /signup are never returned by sign_up_with_email_and_password, because EmailSignUpConfirmation deserialization always succeeds even if the json didn't match, because it has all optional properties.
What is the new behavior?
EmailSignUpConfirmation now has mostly required properties, so it won't deserialize if the result from supabase was an error.
Additional context
I don't remember why I made EmailSignUpConfirmation have all optional properties, I was probably going off of the js auth client as an example, but I can't think of a reason they need to be optional. Let me know if you do. I also removed the Serialize trait since it's only deserialized.