Skip to content

Push docker image with latest/version tag on release, main on main commit #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

halkeye
Copy link

@halkeye halkeye commented Mar 31, 2025

Generally better practice to use a tagged release not "latest" for consistency. I would use the sha, but i like the multi arch.
so release a tagged version on version creation.

Also use the shas for the new actions as thats the suggestion with the comprimised action a few weeks ago

@subdavis
Copy link
Owner

Thanks for the suggestion and the contribution!

I don't mind adding release tags, but I would rather not break the latest release stream for those already using it (which is everyone). Do you mind reverting the build change?

Also use the shas for the new actions as thats the suggestion with the comprimised action a few weeks ago

Interesting, I was not aware of that guidance, so thanks for pointing it out. Where did you get those hashes from? It doesn't match any recent release of https://github.com/docker/build-push-action/releases

@halkeye
Copy link
Author

halkeye commented Mar 31, 2025

@halkeye
Copy link
Author

halkeye commented May 23, 2025

Do you mind reverting the build change?

I'm sorry i totally missed this

Its been reverted. This will mean that the release will release latest, and then the main build will probaly overwrite it
Is it worth disabling latest on the release? Its probably fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants