Implement local filesystem option for studioml experiment storage/database. #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for local (file system based) artifact storage + db provider.
Made LocalArtifactStore a default one for LocalDbProvider.
| elif config['type'].lower() == 's3': | ||
| return S3ArtifactStore(config, verbose=verbose) | ||
| elif config['type'].lower() == 'local': | ||
| return LocalArtifactStore(config, verbose=verbose) |
There was a problem hiding this comment.
Adding "local" option to our selector.
| @@ -0,0 +1,64 @@ | |||
| import calendar | |||
There was a problem hiding this comment.
This implementation is as straightforward as it gets:
basically, we just copy files around with no intent to optimize things.
| @@ -0,0 +1,51 @@ | |||
| import os | |||
| import json | |||
There was a problem hiding this comment.
Database low-level logic implemented simply as directory with file names being the keys
and json values serialized into files themselves.
| blocking_auth=blocking_auth) | ||
| artifact_store = db_provider.get_artifact_store() | ||
|
|
||
| elif db_config['type'].lower() == 'local': |
There was a problem hiding this comment.
Adding "local" option to our selector.
karlmutch
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #386
Simple implementation for experiment storage and/or database in the local (experiment host)
filesystem.
Added basic document describing studioml configuration for this use case.