-
Notifications
You must be signed in to change notification settings - Fork 62
feat(route-helper): Add 'documented' flag for hiding params #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2227958 to
4cae1cd
Compare
zbarbuto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good Idea. Would also love to see the same for endpoints as well as arguments but obviously that can be a separate PR.
|
It already is:
|
|
Ah, right you are... not sure why I thought it didn't exist - must have been thinking of something else https://github.com/strongloop/strong-remoting/blob/master/lib/rest-adapter.js#L570 |
bajtos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
This is great, thank you for the contribution!
|
@slnode ok to test |
|
@STRML could you please update our documentation to mention this new flag too? Here is the page to update: _includes/content/rm-options.md and here are the instructions for contributing to our docs: http://loopback.io/doc/en/contrib/doc-contrib.html |
Add `documented` options for both method & accepts definition. Related: strongloop/loopback-swagger#107
* Update rm-options.md Add `documented` options for both method & accepts definition. Related: strongloop/loopback-swagger#107 * Note OpenAPI/Swagger
|
Awesome, thank you for the doc contribution too! I have landed the patch and released it in Enjoy 😄 |
Description
Adds a
documentedparameter to'accepts'- good for deprecating old parameters.parameterDeprecatedis a thing in OpenAPI 3.0 (https://github.com/OAI/OpenAPI-Specification/pull/637/files) but not in 2.0, so this works well in the meantime and may have other uses even when we get to 3.0.Example
Related issues
None
Checklist
guide