Add missing parameters to Card and BankAccount services #2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroshi-stripe
requested review from
prathmesh-stripe
and removed request for
a team
prathmesh-stripe
approved these changes
Aug 4, 2025
|
|
@jar-stripe There were 15 parameters missing from |
We've listed more in previous changelogs and migration guides. Is it useful to our customers to know the names of the paramters that are now there? if so, it's probably not too noisy to include them. |
mbroshi-stripe
changed the title
mbroshi-stripe
added a commit
that referenced
this pull request
Aug 27, 2025
* Update generated code (#2088) * Update generated code for v1865 and 2025-07-30.basil * Update generated code for v1868 and 2025-07-30.basil * Update generated code for v1868 and 2025-07-30.basil --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> * Bump version to 82.4.0 * Use Go 1.24 in CI (#2097) * Bug fixes for `V1BankAccounts` and `V1Cards` services (#2098) * Add tests * Add hand-written fixes * Fixed services * Add missing parameters to Card and BankAccount services (#2102) * Add tests * Add generated code * Bump version to 82.4.1 * add missing expand param in `get /v1/accounts/{account}/external_accounts` (#2107) * add missing expand param in v1/external_accounts * Revert accidential change * Update generated code (#2101) * Update generated code for v1882 and 2025-07-30.basil * Update generated code for v1928 and 2025-08-27.basil * Update generated code for v1930 and 2025-08-27.basil * Update generated code for v1931 and 2025-08-27.basil * Update generated code for v1932 and 2025-08-27.basil * Update generated code for v1932 and 2025-08-27.basil --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Ramya Rao <[email protected]> * Add section on private preview SDKs in readme (#2108) * Bump version to 82.5.0 * Trigger CI after workflow update --------- Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Ramya Rao <[email protected]> Co-authored-by: Michael Broshi <[email protected]> Co-authored-by: Michael Broshi <[email protected]> Co-authored-by: David Brownman <[email protected]> Co-authored-by: Ramya Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There were two issues opened recently in the
V1CardsandV1BankAccountsservices in the newstripe.Client:In #2098, we addressed the second issue. This PR addresses the first, where a missing
Metadatafield was reported. The root cause turned out to be that when we generated code forV1CardsandV1BankAccountsas part of the newstripe.Clientpattern, there were many missing parameter fields in theCreateparam structs. This PR adds the missing parameters, and handles them appropriately elsewhere in the code.What?
CustomerandAccountpath parameters toBankAccountandCardparams structs where they were missing.if/elsein theV1CardsandV1BankAccountsservices to call the appropriate endpoints.CardCreateParamsandBankAccountCreateParams.AppendToAsCardSourceOrExternalAccountandAppendToAsSourceOrExternalAccountmethods.Changelog
V1CardsandV1BankAccountsservices: ensures the newstripe.Clientpattern supports all parameters previously available inclient.APIfor those two services.