Skip to content

Fix service call without explicit client (redo) #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix service call without explicit client (redo) #2988

merged 1 commit into from
Oct 1, 2024

Conversation

jar-stripe
Copy link
Contributor

@jar-stripe jar-stripe commented Oct 1, 2024 •
edited
Loading

Why?

Re-application of #2978 against master branch

What?

  • changed Service.cs to create a default Requestor if one is not set (using the ApiRequestorAdapter and the current set Client)

@jar-stripe
make sure Service.Requestor always defaults to the settings from the …
8263447 
…currently set client, if a requestor is not explicitly set
@jar-stripe jar-stripe enabled auto-merge (squash) October 1, 2024 18:14
@jar-stripe jar-stripe merged commit 6f20b81 into master Oct 1, 2024
3 of 4 checks passed
@jar-stripe jar-stripe deleted the jar/fix-service-call-no-client branch October 1, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenye-stripe helenye-stripe helenye-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jar-stripe @helenye-stripe