Skip to content

Fix missing phone number in Link signup opt-in flow #11425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2025
Merged

Fix missing phone number in Link signup opt-in flow #11425

merged 3 commits into from
Aug 21, 2025
+137 −24

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Aug 21, 2025 •
edited
Loading

Summary

This pull request fixes an issue with the Link signup opt-in flow where we didn't send the phone number in the signup call. We now retrieve the phone number from the billing details.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   4.8 MiB │   4.8 MiB │ +649 B │  10.5 MiB │  10.5 MiB │ +1.2 KiB 
     arsc │   2.6 MiB │   2.6 MiB │    0 B │   2.6 MiB │   2.6 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │    0 B │  30.1 KiB │  30.1 KiB │      0 B 
      res │ 924.5 KiB │ 924.5 KiB │    0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   3.5 MiB │   3.5 MiB │    0 B │   8.5 MiB │   8.5 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │   -8 B │   1.6 MiB │   1.6 MiB │     -9 B 
    other │ 198.5 KiB │ 198.5 KiB │   -6 B │ 374.9 KiB │ 374.9 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  13.6 MiB │  13.6 MiB │ +635 B │  25.1 MiB │  25.1 MiB │ +1.2 KiB 

         │         raw          │             unique             
         ├───────┬───────┬──────┼───────┬───────┬────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff           
─────────┼───────┼───────┼──────┼───────┼───────┼────────────────
   files │     2 │     2 │    0 │       │       │                
 strings │ 53362 │ 53366 │   +4 │ 49737 │ 49741 │ +4 (+13 -9)    
   types │ 19020 │ 19020 │    0 │ 17306 │ 17306 │  0 (+8 -8)     
 classes │ 14604 │ 14604 │    0 │ 14604 │ 14604 │  0 (+1 -1)     
 methods │ 74369 │ 74370 │   +1 │ 71558 │ 71559 │ +1 (+230 -229) 
  fields │ 48423 │ 48431 │   +8 │ 47467 │ 47475 │ +8 (+265 -257) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6355 │ 6355 │  0
APK 
     compressed     │     uncompressed     │                                       
───────────┬────────┼───────────┬──────────┤                                       
 size      │ diff   │ size      │ diff     │ path                                  
───────────┼────────┼───────────┼──────────┼───────────────────────────────────────
   4.3 MiB │ +647 B │   9.5 MiB │ +1.2 KiB │ ∆ classes.dex                         
   9.3 KiB │   -9 B │   9.1 KiB │     -9 B │ ∆ assets/dexopt/baseline.prof         
  55.1 KiB │   -6 B │ 122.2 KiB │      0 B │ ∆ META-INF/CERT.SF                    
 472.2 KiB │   +2 B │   1.1 MiB │      0 B │ ∆ classes2.dex                        
     241 B │   +1 B │     101 B │      0 B │ ∆ assets/sentry-debug-meta.properties 
───────────┼────────┼───────────┼──────────┼───────────────────────────────────────
   4.8 MiB │ +635 B │  10.7 MiB │ +1.2 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   49737 │ 49741 │ +4 (+13 -9) 
  
  + , countryInferringMethod=
  + BILLING_ADDRESS
  + Ls8/J2;
  + [Ls8/J2;
  + [Lsa/E;
  + [Lsa/N;
  + [Lsa/d0;
  + [Lsa/f0;
  + [Lsa/o0;
  + [Lsa/y;
  + countryInferringMethod
  + phoneEntry
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"4447bb4","r8-mode":"full","version":"8.8.34"}
  
  - Lsa/r0;
  - [Ls8/H2;
  - [Lsa/F;
  - [Lsa/O;
  - [Lsa/e0;
  - [Lsa/g0;
  - [Lsa/p0;
  - [Lsa/z;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"790ee5d","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   17306 │ 17306 │ 0 (+8 -8) 
  
  + Ls8/J2;
  + [Ls8/J2;
  + [Lsa/E;
  + [Lsa/N;
  + [Lsa/d0;
  + [Lsa/f0;
  + [Lsa/o0;
  + [Lsa/y;
  
  - Lsa/r0;
  - [Ls8/H2;
  - [Lsa/F;
  - [Lsa/O;
  - [Lsa/e0;
  - [Lsa/g0;
  - [Lsa/p0;
  - [Lsa/z;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   71558 │ 71559 │ +1 (+230 -229) 
  
  + A8.d0 <init>(H2, m0, boolean)
  + J7.G2 <init>(Boolean, String)
  + J7.k3 <init>(String, String, String, String, String, Locale, Long, String, m1, String, m0, String, String)
  + com.stripe.android.view.CardMultilineWidget getCardNumberErrorListener_payments_core_release() → n0
  + com.stripe.android.view.CardMultilineWidget getCvcErrorListener_payments_core_release() → n0
  + com.stripe.android.view.CardMultilineWidget getExpirationDateErrorListener_payments_core_release() → n0
  + com.stripe.android.view.CardMultilineWidget getPostalCodeErrorListener_payments_core_release() → n0
  + com.stripe.android.view.CardMultilineWidget setCardNumberErrorListener(n0)
  + com.stripe.android.view.CardMultilineWidget setCardNumberErrorListener_payments_core_release(n0)
  + com.stripe.android.view.CardMultilineWidget setCardValidCallback(F)
  + com.stripe.android.view.CardMultilineWidget setCvcErrorListener(n0)
  + com.stripe.android.view.CardMultilineWidget setCvcErrorListener_payments_core_release(n0)
  + com.stripe.android.view.CardMultilineWidget setExpirationDateErrorListener(n0)
  + com.stripe.android.view.CardMultilineWidget setExpirationDateErrorListener_payments_core_release(n0)
  + com.stripe.android.view.CardMultilineWidget setPostalCodeErrorListener(n0)
  + com.stripe.android.view.CardMultilineWidget setPostalCodeErrorListener_payments_core_release(n0)
  + com.stripe.android.view.PaymentAuthWebViewActivity m() → b0
  + com.stripe.android.view.PostalCodeEditText getConfig_payments_core_release() → d0
  + com.stripe.android.view.PostalCodeEditText setConfig_payments_core_release(d0)
  + com.stripe.android.view.ShippingInfoWidget a(f0) → boolean
  + com.stripe.android.view.StripeEditText setAfterTextChangedListener(l0)
  + com.stripe.android.view.StripeEditText setDeleteEmptyListener(m0)
  + com.stripe.android.view.StripeEditText setErrorMessageListener(n0)
  + d6.e <init>(i0, TextView, TextView, TextView, AppCompatImageView)
  + f8.c <init>(o, f, i, H2, e, b)
  + g6.a p0(c, o, f, H2) → F
  + ga.F0 g() → m0
  + h7.D c(String, String, String, String, String, G, ContinuationImpl) → Object
  + h7.D e(String, String, String, String, String, G, ContinuationImpl) → Object
  + h7.y n(String, String, String, String, String, String, String, G, ContinuationImpl) → Object
  + h7.y t(String, String, String, String, String, G, ContinuationImpl) → Object
  + h7.y u(String, String, String, String, String, G, ContinuationImpl) → Object
  + j9.f <init>(H2, int)
  + m2.e <init>(b, m0)
  + p7.D c(String, String, String, String, String, m0, ContinuationImpl) → Object
  + p7.D o(String, String, String, String, String, m0, Long, String, String, String, ContinuationImpl) → Object
  + p7.c <init>(D, String, String, String, String, String, m0, Continuation)
  + p7.w <init>(D, String, String, String, String, String, Long, String, m0, String, String, Continuation)
  + s8.A2 <init>(H2, ContinuationImpl)
  + s8.B2 <init>(H2, String, Continuation)
  + s8.B2 h(Object, Object) → Object
  + s8.B2 o(Object, Continuation) → Continuation
  + s8.C2 <init>(H2, ContinuationImpl)
  + s8.D2 <init>(H2, Continuation)
  + s8.D2 h(Object, Object) → Object
  + s8.D2 o(Object, Continuation) → Continuation
  + s8.E2 <init>(H2, Continuation)
  + s8.F2 <init>(H2, o2, Continuation)
  + s8.G2 <init>(H2, o2, Continuation)
  + s8.G2 h(Object, Object) → Object
  
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/link-signup-opt-in-fix branch from 1b0f319 to 876689c Compare August 21, 2025 21:57
@tillh-stripe tillh-stripe marked this pull request as ready for review August 21, 2025 22:32
@tillh-stripe tillh-stripe requested review from a team as code owners August 21, 2025 22:32
@tillh-stripe tillh-stripe force-pushed the tillh/link-signup-opt-in-fix branch from d7e3c56 to b351f68 Compare August 21, 2025 22:39
carlosmuvi-stripe
carlosmuvi-stripe approved these changes Aug 21, 2025
View reviewed changes
.../stripe/android/paymentelement/confirmation/linkinline/LinkInlineSignupConfirmationOption.kt
) : ConfirmationHandler.Option {
enum class PaymentMethodSaveOption(val setupFutureUsage: ConfirmPaymentIntentParams.SetupFutureUsage?) {
RequestedReuse(ConfirmPaymentIntentParams.SetupFutureUsage.OffSession),
RequestedNoReuse(ConfirmPaymentIntentParams.SetupFutureUsage.Blank),
NoRequest(null)
}

val sanitizedUserInput: UserInput
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@carlosmuvi-stripe carlosmuvi-stripe merged commit 6bd8d78 into master Aug 21, 2025
16 checks passed
@carlosmuvi-stripe carlosmuvi-stripe deleted the tillh/link-signup-opt-in-fix branch August 21, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmuvi-stripe carlosmuvi-stripe carlosmuvi-stripe approved these changes

@samer-stripe samer-stripe samer-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tillh-stripe @carlosmuvi-stripe @samer-stripe