Skip to content

[AddressElement] Move email and phone above the address field on autocomplete mode. #11401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Aug 19, 2025

Summary

On autocomplete enabled, move the address field to the bottom of the form so that keyboard dismisses. To minimize impact, keep the current arrangement on non-autocomplete flows.

Autocomplete disabled:
image
Autocomplete enabled:
image

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.7 KiB │ 302.7 KiB │  0 B │ 456.5 KiB │ 456.5 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   6.4 KiB │   6.4 KiB │  0 B │   6.2 KiB │   6.2 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ -4 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ -4 B │  25.3 MiB │  25.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20686 │ 20686 │ 0 (+0 -0) 
   types │  6505 │  6505 │ 0 (+0 -0) 
 classes │  5269 │  5269 │ 0 (+0 -0) 
 methods │ 31512 │ 31512 │ 0 (+0 -0) 
  fields │ 18233 │ 18233 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3648 │ 3648 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 29.2 KiB │ -4 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.9 KiB │ +2 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │ -4 B │ 130.5 KiB │  0 B │ (total)

@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review August 19, 2025 21:00
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners August 19, 2025 21:00
@carlosmuvi-stripe carlosmuvi-stripe enabled auto-merge (squash) August 19, 2025 21:08
@carlosmuvi-stripe carlosmuvi-stripe merged commit 27b5178 into master Aug 20, 2025
13 checks passed
@carlosmuvi-stripe carlosmuvi-stripe deleted the carlosmuvi/rearrange-form-fields-on-autocomplete branch August 20, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants