Allow dynamic configuration update for controllers

[tinaselenge]

Type of change

Select the type of your PR

• Enhancement

Description

Currently, we restart controller-only nodes if there is any controller relevant configuration changes detected via Pod annotation. The operator can now talk to controller-only nodes directly via Admin API (#11838).

This PR checks configurations of controllers and apply dynamic configurations via Admin API (same as how it's done for broker and mixed nodes) instead of restarting them based on annotation.

closes #10900

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• Write tests
• Make sure all tests pass
• Update documentation
• Check RBAC rights for Kubernetes / OpenShift roles
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging
• Update CHANGELOG.md
• Supply screenshots for visual changes, such as Grafana dashboards

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.90%. Comparing base (089ecbb) to head (a14d9da).
⚠️ Report is 32 commits behind head on main.

Files with missing lines	Patch %	Lines
...perator/cluster/operator/resource/KafkaRoller.java	78.12%	5 Missing and 2 partials ⚠️
...ster/operator/resource/KafkaConfigurationDiff.java	89.28%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11999      +/-   ##
============================================
- Coverage     74.90%   74.90%   -0.01%     
- Complexity     6441     6457      +16     
============================================
  Files           343      343              
  Lines         24324    24339      +15     
  Branches       3196     3209      +13     
============================================
+ Hits          18221    18232      +11     
- Misses         4829     4832       +3     
- Partials       1274     1275       +1     

Files with missing lines	Coverage Δ
...mzi/operator/cluster/model/KafkaConfiguration.java	87.80% <ø> (-1.56%)	⬇️
...tor/cluster/operator/assembly/KafkaReconciler.java	94.60% <ø> (-0.03%)	⬇️
...ster/operator/resource/KafkaConfigurationDiff.java	91.95% <89.28%> (ø)
...perator/cluster/operator/resource/KafkaRoller.java	78.34% <78.12%> (-0.47%)	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[see-quick]

/gha run pipeline=regression

[github-actions]

⏳ System test verification started: link

The following 6 job(s) will be executed:

• regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

[github-actions]

❌ System test verification failed: link

[scholzj]

@tinaselenge One more question ... what are the version limitations for this? Is it 4.0+? Also, what happens during upgrade from for example Kafka 3.8? Is this part skipped because for example container image changed and the pod is rolled anyway?

[tinaselenge]

@tinaselenge One more question ... what are the version limitations for this? Is it 4.0+? Also, what happens during upgrade from for example Kafka 3.8? Is this part skipped because for example container image changed and the pod is rolled anyway?

Yes, it is limited to 4.0+ as it builds on #11838. And yes I think so... because we apply dynamic updates only if we don't need to restart the node. If the container image has changed, it will be restarted before getting to this config part.

[scholzj]

Few more nits. LGTM overall.

[scholzj]

LGTM assuming the tests pass. Thanks.

[scholzj]

/gha run pipeline=regression,upgrade

[github-actions]

⏳ System test verification started: link

The following 10 job(s) will be executed:

• regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
• regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
• regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)
• upgrade-azp_kraft_upgrade-amd64 (oracle-vm-4cpu-16gb-x86-64)
• upgrade-azp_kafka_upgrade-amd64 (oracle-vm-4cpu-16gb-x86-64)
• upgrade-azp_kraft_upgrade-arm64 (oracle-vm-4cpu-16gb-arm64)
• upgrade-azp_kafka_upgrade-arm64 (oracle-vm-4cpu-16gb-arm64)

Tests will start after successful build completion.

[scholzj]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[scholzj]

/azp run upgrade

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[github-actions]

🎉 System test verification passed: link