Charging station quest #6531

HugoTHOLLON · 2025-09-30T16:14:04Z

Adding the following quests suggested in #6457:

How many bikes can be charged here at the same time?
How many scooters can be charged here at the same time?

For now, the icon of the quest 2 form is a bike and need to be replaced with a scooter. The icons of both quests are the same as the original charging_station_capacity quest, they could be replaced.

This PR include a french translation of the quests.

Added and filled the backlog for first sprint

…e#6457

…lete#6457, the icons of the quest need to be updated

… quest

matkoniecz · 2025-09-30T16:29:19Z

very quick comment

This PR include a french translation of the quests.

this is not needed - translations are pulled from translation service and override previous contents, see https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING.md#translating-the-app

Before each release, translations are pulled in from POEditor. Please, use POEditor for translating. Manual changes submitted as Pull Requests will not be merged as they do not help the project.

app/src/commonMain/kotlin/de/westnordost/streetcomplete/ApplicationConstants.kt

paulklie · 2025-09-30T17:38:17Z

...nordost/streetcomplete/quests/charging_station_capacity/AddScooterChargingStationCapacity.kt

+
+    override val elementFilter = """
+        nodes, ways with
+          amenity = charging_station


I think we should also filter out any charging stations with motor_vehicle=yes/designated since some charging stations can be used for both scooters / bikes and cars.

Hm well, I guess the situation with these vehicle tags is a bit difficult and/or undocumented.

Is a amenity = charging_station and scooter ~ yes|designated supposed to be a scooter-only charging station? Or are motor vehicles generally allowed unless specified otherwise? The wiki makes it sound like it is supposed to be the latter.
On the other hand, unless specified explicitly in the wiki (and even then), we have to assume that we'll find both in the wild.

I am thinking that maybe it would be safer to always tag capacity:scooter for clarity because amenity=charging_station is . (Same for bicycles)

Could we not reuse the solution in #6536?
Tag capacity:scooter if the charging station supports other modes of transport and capacity if not?

The problem is that the list of "other modes of transport" is somewhat open ended.

My message is the duplicate of one I made below.

@westnordost I'm don't really see the problem about the "other modes of transport" behing open ended. A charging station with multiple vehicule types (e.g. bicycle, car and scooter) might have informations about the bicycle and car's capacity but not the scooter's.

paulklie · 2025-09-30T17:38:33Z

...estnordost/streetcomplete/quests/charging_station_capacity/AddBikeChargingStationCapacity.kt

+    override val elementFilter = """
+        nodes, ways with
+          amenity = charging_station
+          and bicycle ~ yes|designated


app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/QuestsModule.kt

paulklie · 2025-09-30T17:39:47Z

Nice work so far!

paulklie · 2025-09-30T18:11:30Z

I also think the quests are better placed together with the car one in quests/charging_station_capacity instead of a new directory.

app/src/androidMain/res/values/strings.xml

westnordost · 2025-10-01T18:09:32Z

...nordost/streetcomplete/quests/charging_station_capacity/AddScooterChargingStationCapacity.kt

+
+    override val elementFilter = """
+        nodes, ways with
+          amenity = charging_station


Hm well, I guess the situation with these vehicle tags is a bit difficult and/or undocumented.

Is a amenity = charging_station and scooter ~ yes|designated supposed to be a scooter-only charging station? Or are motor vehicles generally allowed unless specified otherwise? The wiki makes it sound like it is supposed to be the latter.
On the other hand, unless specified explicitly in the wiki (and even then), we have to assume that we'll find both in the wild.

I am thinking that maybe it would be safer to always tag capacity:scooter for clarity because amenity=charging_station is . (Same for bicycles)

...streetcomplete/quests/scooter_charging_station_capacity/AddScooterChargingStationCapacity.kt

...rdost/streetcomplete/quests/bike_charging_station_capacity/AddBikeChargingStationCapacity.kt

westnordost · 2025-10-01T18:14:28Z

I also think the quests are better placed together with the car one in quests/charging_station_capacity instead of a new directory.

I don't mind either way. Don't see a reason for that.

paulklie · 2025-10-01T18:33:54Z

I also think the quests are better placed together with the car one in quests/charging_station_capacity instead of a new directory.

I don't mind either way. Don't see a reason for that.

If #6536 gets merged there will be shared code that all quests might use in that directory

app/src/commonMain/kotlin/de/westnordost/streetcomplete/ApplicationConstants.kt

…ationConstants.kt Co-authored-by: Mateusz Konieczny <[email protected]>

…lter and tag to look for capacity:scooter/bicycle instead of capacity. Adding an icon for the quests. Removing empty lines from QuestsModule.

...ost/streetcomplete/quests/charging_station_capacity/AddScooterChargingStationCapacityForm.kt

app/src/androidMain/res/drawable/ic_quest_bicycle_charger_capacity.xml

westnordost · 2025-10-02T12:02:04Z

...nordost/streetcomplete/quests/charging_station_capacity/AddScooterChargingStationCapacity.kt

+
+    override val elementFilter = """
+        nodes, ways with
+          amenity = charging_station


The problem is that the list of "other modes of transport" is somewhat open ended.

…r_capacity.svg

HugoTHOLLON · 2025-10-03T15:34:54Z

@westnordost I'm don't really see the problem about the "other modes of transport" behing open ended. A charging station with multiple vehicule types (e.g. bicycle, car and scooter) might have informations about the bicycle and car's capacity but not the scooter's.

HugoTHOLLON · 2025-10-13T15:30:30Z

So... I'm not sure what to do now @westnordost @paulklie.

Is my pull request correct ?

Do I need to resolve the 2 remaining conflicts even if no modifications were made ?

paulklie · 2025-10-13T17:44:38Z

Is my pull request correct ?

I think we need to resolve the discussion in #6536 first, and decide if asking for the capacity of bike / scooter charging stations even makes sense.

Pardon me, I should have considered this before adding it to #6457

NicodeH and others added 29 commits September 3, 2025 11:13

Rename README.md to README.adoc

4501ce5

Update README.adoc

b901e47

Update README.adoc

2ca0855

Update README.adoc

933971a

Update README.adoc

2c2511a

Initialisation des docs

523de1d

Update doc_tech.adoc

9007f3f

Update doc_user.adoc

279d069

Changement du badge de licence

b9a4260

Adding cr and odj folder

5ba5e00

Ajout du lien vers le CR

e877446

Correction du lien vers cr de télétravail

8cb190a

Ajout du cr de tt du 04 septembre

4c9b2c4

Add the Devis to the docs

1f61a05

Update du README.adoc

abae682

Adding CR and ODJ Sprint 1

8a4f681

Update ODJ/CR section with links and notes

bd2d066

Merge branch 'streetcomplete:master' into master

8e0dd92

Create sprint 1 backlog

650926e

Added and filled the backlog for first sprint

Add links for CR AND ODJ part2 for Sprint 1 in README

accd989

Adding the files

2476c62

Added AddBikeChargingStationCapacity quest suggested in streetcomplet…

fc1b951

…e#6457

Added AddScooterChargingStationCapacity quest suggested in streetcomp…

cd6ebd9

…lete#6457, the icons of the quest need to be updated

Restoring README to it's original state

da23fd9

Removing docs folder in branch

cba0a3f

Merge branch 'streetcomplete:master' into charging_station_quest

b0b232f

Changing the app name constant to inform that we are working on a branch

c463b23

Adding a french translation to the bike and scooter charging stations…

4cb2bba

… quest

Merge branch 'streetcomplete:master' into charging_station_quest

ce13172

paulklie requested changes Sep 30, 2025

View reviewed changes

paulklie mentioned this pull request Sep 30, 2025

Motorcycle parking fee quest #6532

Merged

westnordost requested changes Oct 1, 2025

View reviewed changes

typo

3e8c882

matkoniecz reviewed Oct 2, 2025

View reviewed changes

app/src/commonMain/kotlin/de/westnordost/streetcomplete/ApplicationConstants.kt Outdated Show resolved Hide resolved

HugoTHOLLON and others added 2 commits October 2, 2025 11:00

Update app/src/commonMain/kotlin/de/westnordost/streetcomplete/Applic…

1b90a2d

…ationConstants.kt Co-authored-by: Mateusz Konieczny <[email protected]>

Moving all charging station quests to the same directory. Changing fi…

b9715f8

…lter and tag to look for capacity:scooter/bicycle instead of capacity. Adding an icon for the quests. Removing empty lines from QuestsModule.

westnordost reviewed Oct 2, 2025

View reviewed changes

paulklie mentioned this pull request Oct 3, 2025

Aerialway bicycle quest #6544

Merged

Adding the quest icon as an SVG in /res/graphics/quest/bicycle_charge…

ea6f7f4

…r_capacity.svg

westnordost mentioned this pull request Oct 5, 2025

AddChargingStationCapacity: answer specific capacity #6536

Open

Uh oh!

Charging station quest #6531

Are you sure you want to change the base?

Charging station quest #6531

Uh oh!

Conversation

HugoTHOLLON commented Sep 30, 2025

Uh oh!

matkoniecz commented Sep 30, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paulklie commented Sep 30, 2025

Uh oh!

paulklie commented Sep 30, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

westnordost commented Oct 1, 2025

Uh oh!

paulklie commented Oct 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HugoTHOLLON commented Oct 3, 2025

Uh oh!

HugoTHOLLON commented Oct 13, 2025

Uh oh!

paulklie commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

paulklie commented Oct 13, 2025 •

edited

Loading