Skip to content

fix: base URL-aware import using ApiClient.getUrl() #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

fix: base URL-aware import using ApiClient.getUrl() #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jellyfin.Plugin.Streamyfin/Pages/Application/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default function (view, params) {

// init code here
view.addEventListener('viewshow', (e) => {
import("/web/configurationpage?name=shared.js").then((shared) => {
import(window.ApiClient.getUrl("web/configurationpage?name=shared.js")).then((shared) => {
shared.setPage("Application");

setOptions(shared.getJsonSchema());
Expand Down
2 changes: 1 addition & 1 deletion Jellyfin.Plugin.Streamyfin/Pages/Notifications/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function (view, params) {

// init code here
view.addEventListener('viewshow', (e) => {
import("/web/configurationpage?name=shared.js").then((shared) => {
import(window.ApiClient.getUrl("web/configurationpage?name=shared.js")).then((shared) => {
shared.setPage("Notifications");

document.getElementById("notification-endpoint").innerText = shared.NOTIFICATION_URL
Expand Down
2 changes: 1 addition & 1 deletion Jellyfin.Plugin.Streamyfin/Pages/Other/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default function (view, params) {

// init code here
view.addEventListener('viewshow', (e) => {
import("/web/configurationpage?name=shared.js").then((shared) => {
import(window.ApiClient.getUrl("web/configurationpage?name=shared.js")).then((shared) => {
shared.setPage("Other");

homePage().options.length = 0;
Expand Down
4 changes: 2 additions & 2 deletions Jellyfin.Plugin.Streamyfin/Pages/YamlEditor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ export default function (view, params) {

// init code here
view.addEventListener('viewshow', (e) => {
import("/web/configurationpage?name=shared.js").then((shared) => {
import(window.ApiClient.getUrl("web/configurationpage?name=shared.js")).then((shared) => {
shared.setPage("Yaml");
return shared;
}).then(async (shared) => {
// Import monaco after shared resources and wait until its done before continuing
if (!window.monaco) {
Dashboard.showLoadingMsg();
await import("/web/configurationpage?name=monaco-editor.bundle.js")
await import(window.ApiClient.getUrl('web/configurationpage?name=monaco-editor.bundle.js'))
}

const Page = {
Expand Down
2 changes: 1 addition & 1 deletion Jellyfin.Plugin.Streamyfin/Pages/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export const StreamyfinTabs = () => [
// region on Shared init
if (!window.Streamyfin?.shared) {
// import json-yaml library
import("/web/configurationpage?name=js-yaml.js").then((jsYaml) => {
import(window.ApiClient.getUrl("web/configurationpage?name=js-yaml.js")).then((jsYaml) => {
tools.jsYaml = jsYaml;

//fetch default configuration
Expand Down