Support throwIfNoEntry in StatOptions
#782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mausworks
force-pushed
the
fix/support-throwIfNoEntry
branch
from
24f86cc to
23aa210
Compare
This option is available since node v14 and is quite useful
mausworks
force-pushed
the
fix/support-throwIfNoEntry
branch
from
23aa210 to
80cf803
Compare
mausworks
commented
Nov 24, 2021
mausworks
changed the title
throwIfNoEntry: false in StatOptionsthrowIfNoEntry in StatOptions
streamich
approved these changes
Nov 24, 2021
Comment on lines
1525
to
+1532
| lstatSync(path: PathLike): Stats<number>; | ||
| lstatSync(path: PathLike, options: { bigint: false }): Stats<number>; | ||
| lstatSync(path: PathLike, options: { bigint: true }): Stats<bigint>; | ||
| lstatSync(path: PathLike, options?: IStatOptions): Stats { | ||
| return this.lstatBase(pathToFilename(path), getStatOptions(options).bigint as any); | ||
| lstatSync(path: PathLike, options: { throwIfNoEntry?: true | undefined }): Stats<number>; | ||
| lstatSync(path: PathLike, options: { bigint: false; throwIfNoEntry?: true | undefined }): Stats<number>; | ||
| lstatSync(path: PathLike, options: { bigint: true; throwIfNoEntry?: true | undefined }): Stats<bigint>; | ||
| lstatSync(path: PathLike, options: { throwIfNoEntry: false }): Stats<number> | undefined; | ||
| lstatSync(path: PathLike, options: { bigint: false; throwIfNoEntry: false }): Stats<number> | undefined; | ||
| lstatSync(path: PathLike, options: { bigint: true; throwIfNoEntry: false }): Stats<bigint> | undefined; | ||
| lstatSync(path: PathLike, options?: IStatOptions): Stats | undefined { |
Owner
There was a problem hiding this comment.
Seems like these type overloads are slowly getting out of control.
Contributor
Author
There was a problem hiding this comment.
Indeed! 😅
Should probably be revised if a future version of NodeJS ships with new options.
Owner
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Fantastic. Thanks for your quick review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #781