Skip to content

Support promises API in patchFs #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Support promises API in patchFs #217

merged 1 commit into from
Jul 18, 2025

Conversation

aleung
Copy link
Contributor

@aleung aleung commented Feb 9, 2021 •
edited
Loading

@aleung aleung mentioned this pull request Feb 9, 2021
Closed
@aleung
Copy link
Contributor Author

aleung commented Apr 21, 2021

@streamich Would you review this PR?

@G-Rath
Copy link
Collaborator

G-Rath commented Jun 2, 2023

@aleung sorry for the delay - is there a reason why you've used Object.defineProperty instead of just assigning like we do with other methods?

@aleung
Copy link
Contributor Author

aleung commented Jun 8, 2023

It was a long time since I wrote the code. I can't exactly remember the reason.

I think I don't want promises to be a normal property of the object:

By default, properties added using Object.defineProperty() are not writable, not enumerable, and not configurable.

More explanation is in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty#description

@sladg
Copy link

sladg commented Nov 20, 2023

Hey there! Is there a reason this is not merged by now? :) I'm looking forward to use the library, however, this is a dealbreaker as I need to patch promise calls to FS.

@G-Rath
Copy link
Collaborator

G-Rath commented Jul 18, 2025

we can look at landing this PR if someone wouldn't mind rebasing / recreating it so CI can run

@aleung
Copy link
Contributor Author

aleung commented Jul 18, 2025

@G-Rath Rebase done. But not sure how to make CI run.

@G-Rath G-Rath merged commit 182ea8b into streamich:master Jul 18, 2025
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 18, 2025
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
08fc2cc 
# [1.1.0](v1.0.6...v1.1.0) (2025-07-18)

### Features

* support promises in patchFs ([#217](#217)) ([182ea8b](182ea8b))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Promises
3 participants
@aleung @G-Rath @sladg