Virtualized list with @tanstack/react-virtual #1964
Conversation
🦋 Changeset detectedLatest commit: 573c5fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
HichamELBSI
added
source: design-system
HichamELBSI
force-pushed
the
fix/virtualized-combobox
branch
2 times, most recently
from
e5b8141 to
8228a8e
Compare
| onChange, | ||
| onClear, | ||
| onCreateOption, | ||
| virtualized = false, |
There was a problem hiding this comment.
Question here: I get that we want to keep the default behaviour as much as possible but wouldn't it be also possible to turn on the virtualization automatically if the number of items exceed a limit (for example for a dynamic list we don't know how many elements it could have)?
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@strapi/design-system': major | |||
There was a problem hiding this comment.
Since it's not really breaking anything, is it really necessary to bump to a major?
| '@strapi/ui-primitives': major | ||
| --- | ||
|
|
||
| Add virtualization as an option to combobox list |
There was a problem hiding this comment.
We decided to also stick to conventional commits for changesets messages format :)
HichamELBSI
force-pushed
the
fix/virtualized-combobox
branch
from
d83aa0f to
3f031d4
Compare
|
There are some issue with the combobox input events (change, clear, blur) because of the virtualization. I'll post pone the fix on the combobox performance. |
HichamELBSI
added
the
flag: don't merge
HichamELBSI
force-pushed
the
fix/virtualized-combobox
branch
from
3f031d4 to
75e38fd
Compare
HichamELBSI
force-pushed
the
fix/virtualized-combobox
branch
from
75e38fd to
573c5fa
Compare
|
|
The issue has been fixed by disabling the virtualization as soon as the list is being filtered. It solves most of the issues. |
HichamELBSI
removed
the
flag: don't merge
2 participants
What does it do?
Add optional virtualized list for combobox (implemented to the timepicker).
Why is it needed?
To improve the TimePicker (and Combobox) performances on long list.
How to test it?
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request
Before fix: https://www.loom.com/share/07fc90f6b02543b48e18a3f036150c70
After fix: https://www.loom.com/share/f740d3fd31424e6285ea05517bebb342